Skip to content

Refit weight name map removal#4342

Merged
cehongwang merged 2 commits into
mainfrom
cehongw/weight-nsmae-map-removal
Jun 26, 2026
Merged

Refit weight name map removal#4342
cehongwang merged 2 commits into
mainfrom
cehongw/weight-nsmae-map-removal

Conversation

@cehongwang

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@cehongwang cehongwang requested a review from narendasan June 13, 2026 00:15
@meta-cla meta-cla Bot added the cla signed label Jun 13, 2026
@cehongwang cehongwang requested a review from zewenli98 June 13, 2026 00:15
@github-actions github-actions Bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 13, 2026
@github-actions github-actions Bot requested a review from apbose June 13, 2026 00:16

@narendasan narendasan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no breaking change right, existing weight caches should just get ignored?

@zewenli98

Copy link
Copy Markdown
Collaborator

LGTM except a conflict needs to be resolved. and then rebase and make sure CI passes

@narendasan

Copy link
Copy Markdown
Collaborator

@cehongwang can you rebase test and merge?

@cehongwang cehongwang force-pushed the cehongw/weight-nsmae-map-removal branch from dac3ba2 to 0bdde27 Compare June 26, 2026 05:22
@cehongwang cehongwang force-pushed the cehongw/weight-nsmae-map-removal branch from 0bdde27 to 3fc6874 Compare June 26, 2026 05:23
@cehongwang cehongwang merged commit e1cbee5 into main Jun 26, 2026
127 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants